concurrent-ruby icon indicating copy to clipboard operation
concurrent-ruby copied to clipboard

Should RubySingleThreadExecutor be marked to be a SerialExecutorService again?

Open meineerde opened this issue 1 year ago • 2 comments

In 455203e, the RubySingleThreadExecutor implementation was updated to use the generic RubyThreadPoolExecutor. With that change, the previously included SerialExecutorService module was removed, resulting in RubySingleThreadExecutor#serialized? now returning false.

I'm wondering if that is actually correct, given that we still have exactly one thread which executes a single task at a time which is pop'ed from the queue serially?

Shouldn't the module be included again, or more generally: shouldn't RubyThreadPoolExecutor#serialized? always return true if its max_threads is <= 1?

meineerde avatar Nov 01 '24 18:11 meineerde