rubocop-rails icon indicating copy to clipboard operation
rubocop-rails copied to clipboard

Deprecate `IgnoredMethods` option

Open koic opened this issue 3 years ago • 1 comments

Follow up https://github.com/rubocop/rubocop/pull/10829.

This PR deprecates IgnoredMethods option in integrate to AllowedMethods and AllowedPatterns option. It requires RuboCop 1.33.0 or higher.


Before submitting the PR make sure the following are checked:

  • [x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • [x] Wrote good commit messages.
  • [ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
  • [x] Feature branch is up-to-date with master (if not - rebase it).
  • [x] Squashed related commits together.
  • [x] Added tests.
  • [x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • [x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • [x] If this is a new cop, consider making a corresponding update to the Rails Style Guide.

koic avatar Jul 24 '22 16:07 koic

https://github.com/rubocop/rubocop/pull/10831 is required to resolve the build errors.

koic avatar Jul 24 '22 16:07 koic

@koic When is a release expected with these changes?

co-anton-s avatar Sep 05 '22 13:09 co-anton-s

Scheduled for the second half of this week. Please wait for a little while.

koic avatar Sep 05 '22 13:09 koic

Scheduled for the second half of this week. Please wait for a little while.

Good. Thank you!

co-anton-s avatar Sep 05 '22 13:09 co-anton-s

@anton-co RuboCop Rails 2.16 has been released. Thank you! https://github.com/rubocop/rubocop-rails/releases/tag/v2.16.0

koic avatar Sep 09 '22 09:09 koic