rtucek
vue3 port
- use composition api vs. vue-class-component/vue-property-decorator, via
- fix v-model breaking changes for vue 3
- update demo app accordingly
- implement event bus via mitt
- build with vite; remove vue cli
- update dep for vuedraggable; change API interaction with vuedraggable to deal with proxied children, due to requirement for itemKey per draggable.
- update miscellaneous deps for building with vite, linting, etc
- update tests to use vitest
@rtucek I realized my branch did commit build files. I did this so my app could consume them.
Do you want a PR without build files?
BTW, very impressive work with the complete test coverage. I was able to get most of the port done in a day but struggled with some test failures for about a week and it turns out there were some very subtle port issues for vue 3 and it's proxy handling of components.
@kwesterfeld2 woha, this is amazing.
I'll check when I'm home again as I'm traveling right now for 1 week.
No, you don't need to provide build files, as I'm creating them anyway prior tagging a release.
Also thank you for the credit on testing :) I had to add it, because I broke it way to often by myself :laughing:
Do you think we'd also have to adjust the docs? I'm sort of thinking to to split the docs for Vue 2 and Vue 3 and duplicate + port the Codesandbox samples.
I'm not sure how to proceed with releasing the component for vue 3. What I see some developers do is bump the major version and declare that "if you want vue 2 support use version prior." Something like that.
Also, I see that lint checks are failing, but that's likely because of the way in which the entire stack is rebuilt using new versions of everything. Also, I'm not sure I'm good enough at Typescript to adjust code to fix some of the warnings it finds. I've been doing JS a very long time but TS is something I don't dabble much in.
Let me know if you need a new PR with anything adjusted.
@kwesterfeld2 hello, I have a small question (about the vue3), how can be talked about?
Happy to answer any questions
From: Davidbadasyan @.> Sent: Thursday, August 3, 2023 4:17:12 AM To: rtucek/vue-query-builder @.> Cc: Kurt Westerfeld @.>; Mention @.> Subject: Re: [rtucek/vue-query-builder] vue3 port (PR #93)
@kwesterfeld2https://github.com/kwesterfeld2 hello, I have a small question, how can talked?
— Reply to this email directly, view it on GitHubhttps://github.com/rtucek/vue-query-builder/pull/93#issuecomment-1664071143, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJC6YIUBQEZTK36EE5D457DXTOXGRANCNFSM6AAAAAASHBCPBA. You are receiving this because you were mentioned.Message ID: @.***>
I have copied your changes and made a build to use this vue query builder but it is giving me some strange error did you use it was it fine?
cannot read properties of undefined (reading '_init') vue
we use the fork I am maintaining but the changes should be aligned with my PR
Get Outlook for iOShttps://aka.ms/o0ukef
From: Davidbadasyan @.> Sent: Thursday, August 3, 2023 6:48:10 AM To: rtucek/vue-query-builder @.> Cc: Kurt Westerfeld @.>; Mention @.> Subject: Re: [rtucek/vue-query-builder] vue3 port (PR #93)
I have copied your changes and made build to use this vue query builder but it is giving me some strange error did you used it was it fine?
— Reply to this email directly, view it on GitHubhttps://github.com/rtucek/vue-query-builder/pull/93#issuecomment-1664312994, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJC6YIQTCJZWTBDUSX7MIRTXTPI4VANCNFSM6AAAAAASHBCPBA. You are receiving this because you were mentioned.Message ID: @.***>
did you use the vue-query-builder that you made for vue 3 and how you implemented it in your project or do you still wait to merge pr and after do it?