diff2html icon indicating copy to clipboard operation
diff2html copied to clipboard

Highlight.js themes don't work correctly

Open tomastrajan opened this issue 6 years ago • 4 comments

I have been trying to replace github.min.css theme with other highlight.js themes but without success. The text color is taken but the whole result is a combination of some default styles and theme which looks weird? bu

tomastrajan avatar Feb 02 '19 16:02 tomastrajan

Also, my css and scripts seem to be ok hmm... bug2

tomastrajan avatar Feb 02 '19 16:02 tomastrajan

@tomastrajan sorry for the delay getting back to you but I did not get time to actually test it. Today I did a quick check and seems like a basic styling issue.

If you change the order of the styles and import the atom one last it will be a bit better but still not work. When I did this I never intended to support multiple styles and for that reason it does not work by default.

If you are interested and taking a look and understanding what needs to be done to fix this I would gladly accept a contribution.

rtfpessoa avatar Feb 07 '19 22:02 rtfpessoa

@rtfpessoa thank you for getting back to me, yeah I might have a look but cant promise anything ;)

tomastrajan avatar Feb 07 '19 22:02 tomastrajan

@rtfpessoa btw thanks for the killer lib, it's very useful!

tomastrajan avatar Feb 07 '19 22:02 tomastrajan