rtek

Results 23 comments of rtek

In the case of named xs:simpleType, you may want to keep the empty class that contains the constants. It's convenient to have them during development. ``` xml ``` ``` php...

Have you considered making enum class generation optional via flag and also doing the doc-block route? Everyone gets covered that way.

I would also include the list of possible values in the generated comments / doc block too. That way people still have access via IDE if they disable generated enum...

Yes - Id like to wrap this up. Should I close and re-open to get a fresh review going?

As a workaround i just altered the XSD to drop the second sequence and remove the choice, since i didnt need it anyways - e.g. ``` ``` related https://github.com/goetas-webservices/xsd2php/issues/170

> Note: As of PHP 8.3.0, calling this method with a single argument is deprecated, use ReflectionProperty::setValue(null, $value) instead. Ran into this and I agree.

Some more research: The issue occurs when the cache dir is not the same as the working directory. The parallel runner saves file hashes at the absolute path (https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/master/src/Runner/Runner.php#L282) but...

I was able to fix the issue by changing this line to `getRealpath()`: https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/master/src/Runner/FileFilterIterator.php#L90 I'll try to write some tests to get a pr against this.

This is still relevant - caching does not work for parallel execution when the cache path is not the root directory.

Hello Gentlemen - I was unable to come up with a clean test case and/or PR for this since there are a few ways to fix it based on how...