redux-persist-immutable icon indicating copy to clipboard operation
redux-persist-immutable copied to clipboard

Upgrade redux-persist-transform-immutable

Open aghoneim92 opened this issue 7 years ago • 8 comments

redux-persist-transform-immutable v4 uses transit-js, which takes up 18kb of the bundle size, gzipped and minified. It would be nice to use v5 which uses a much lighter library. I could open a PR for this but wanted to know if it would break anything :)

aghoneim92 avatar Feb 27 '18 20:02 aghoneim92

Very interested in this as well

chrisgbaker avatar Mar 01 '18 16:03 chrisgbaker

What is needed to do this? I can go ahead and get the ball rolling.

chrisgbaker avatar Apr 25 '18 20:04 chrisgbaker

@chrisgbaker I have already upgraded it in a fork on my account. After upgrading redux-persist-transform-immutable, there was a bug in the new library it used instead of transit-js where it tried to instantiate classes without new, this caused a runtime error with Babel-compiled projects. I also upgraded that and added everything to this branch: https://github.com/aghoneim92/redux-persist-immutable/tree/upgrade-remotedev-serialize

aghoneim92 avatar Apr 26 '18 14:04 aghoneim92

@aghoneim92 Nice! Any chance we could get a PR into here for a release?

chrisgbaker avatar May 09 '18 18:05 chrisgbaker

@aghoneim92 thoughts on that PR?

chrisgbaker avatar May 23 '18 16:05 chrisgbaker

What needs to be done to get @aghoneim92's changes merged and a new release cut? Still very interested in having the dependency updated so I can drop transit-js from my bundle.

chrisgbaker avatar Jul 06 '18 14:07 chrisgbaker

@chrisgbaker #37 and #41 are both open, but the library doesn't seem to be active or maintained anymore. If we couldn't get this merged, I suggest you link to my fork or your own fork of that one with a github value in your package.json

aghoneim92 avatar Jul 06 '18 19:07 aghoneim92

Hey in case anyone comes across this you can use this package

FoxxMD avatar Jul 02 '20 20:07 FoxxMD