Russell Dunphy

Results 18 comments of Russell Dunphy

I guess I'm used to seeing the two lines overlaid, rather than a growth series, so not sure which one I'd find easier to read on a day to day...

I have made a simple repo that reproduces this issue using a barrel file provided by a large third-party library, in this case Material UI icons: https://github.com/rsslldnphy/jest-barrel-files On my machine,...

> @rsslldnphy for material specifically, which is a quite big library, I isolate the parts of the library my code actually uses in a re-exported barrel file: > > ```ts...

FWIW this is what I've done, feels pretty bad but does seem to work: ```typescript export default withPageAuthRequired( Layout as AppRouterPageRoute, ) as React.FC; ```

For posterity, here are the reasons I don't agree with this pull request. Sorry Gav! ## Making Option[[]], Option[{}] and Option[""] return None Looked at a certain way, it does...

> I think it is kind of like const assertions on generic parameters instead of doing as const in calling code. It makes a lot of sense to say that...

Hi! Did you get round to making this PR? Am running into the same issue now - we call our folders `packages` rather than `packs` - could that be the...

@flexdinesh I'm facing the same thing and I believe this is a real issue: your proposed solution does prevent form submit when hitting enter with no options to choose from,...