rsocket-py icon indicating copy to clipboard operation
rsocket-py copied to clipboard

test_connection_never_established wrong

Open gabis-precog opened this issue 3 years ago • 5 comments

test_connection_never_established doesn't really attempt to reconnect 3 times and fail as specified. only attempts connection once and then throws the expected exception (as visible in logs)

gabis-precog avatar Jun 21 '22 18:06 gabis-precog

Hi @gabis-precog, is this being actively worked upon, if not than can I work on this?

ark-tik avatar Feb 18 '24 14:02 ark-tik

I actually haven't checked in a long time if this still happens. Go for it :)

jell-o-fishi avatar Feb 18 '24 15:02 jell-o-fishi

I am unsure if this is an actual problem in the code or just in the way it is tested. The solution might be a different test.

jell-o-fishi avatar Feb 18 '24 15:02 jell-o-fishi

@KartikShrivastava. upon further inspection, the test seems meaningless. if you really feel like doing something about , i suggest devising a proper way of testing entire reconnect mechanism, retry on disconnect, and on initial connect failure.

jell-o-fishi avatar Feb 18 '24 18:02 jell-o-fishi

Thanks for your inputs @jell-o-fishi, will continue in that direction

ark-tik avatar Feb 19 '24 03:02 ark-tik