rsocket-kotlin icon indicating copy to clipboard operation
rsocket-kotlin copied to clipboard

Cleanup build logic

Open whyoleg opened this issue 1 year ago • 1 comments

Overall, the idea is that latest Gradle/KGP versions and suggesting allowed to cleanup some code.

Just build-related changes:

  • align build-logic naming with what Gradle suggests
    • move build-logic to root of the project
  • introduce build-logic-settings
  • remove build-parameters
  • move kotlin version to Version Catalog
  • extract Gradle related versions to Version Catalog
  • drop target-specific convention plugins, as KGP now generates accessors
  • use targets helpers in projects instead of convention plugins
  • drop template convention plugins, leave only library - inline other usages

Code/functionality related changes:

  • run tests on JDK 21
  • minor cleanup in the publication script
  • create test aggregate tasks (to run by CI)
  • reduce usages of OptIns
  • use jvm-default=all (easier compatibility in future)
  • drop test server completely for now from rsocket-transport-tests

whyoleg avatar Mar 02 '24 08:03 whyoleg

Test Results

  699 files  ±0    699 suites  ±0   37m 7s :stopwatch: -1s 2 179 tests ±0  1 950 :white_check_mark: ±0  229 :zzz: ±0  0 :x: ±0  4 562 runs  ±0  4 032 :white_check_mark: ±0  530 :zzz: ±0  0 :x: ±0 

Results for commit d5c1b35f. ± Comparison against base commit 2239c5ca.

This pull request removes 201 and adds 201 tests. Note that renamed tests count towards both.
io.rsocket.kotlin.ConnectionEstablishmentTest ‑ requesterReleaseSetupPayloadOnFailedAcceptor[js, browser, ChromeHeadless122.0.6261.69, Linuxx86_64]
io.rsocket.kotlin.ConnectionEstablishmentTest ‑ responderRejectSetup[js, browser, ChromeHeadless122.0.6261.69, Linuxx86_64]
io.rsocket.kotlin.RSocketCustomErrorTest ‑ shouldFailBelowLowerBond[js, browser, ChromeHeadless122.0.6261.69, Linuxx86_64]
io.rsocket.kotlin.RSocketCustomErrorTest ‑ shouldFailOverUpperBond[js, browser, ChromeHeadless122.0.6261.69, Linuxx86_64]
io.rsocket.kotlin.RSocketCustomErrorTest ‑ shouldSuccessfullyCreateAtLowerBond[js, browser, ChromeHeadless122.0.6261.69, Linuxx86_64]
io.rsocket.kotlin.RSocketCustomErrorTest ‑ shouldSuccessfullyCreateAtUpperBond[js, browser, ChromeHeadless122.0.6261.69, Linuxx86_64]
io.rsocket.kotlin.RSocketCustomErrorTest ‑ shouldSuccessfullyCreateNearLowerBond[js, browser, ChromeHeadless122.0.6261.69, Linuxx86_64]
io.rsocket.kotlin.RSocketCustomErrorTest ‑ shouldSuccessfullyCreateNearUpperBond[js, browser, ChromeHeadless122.0.6261.69, Linuxx86_64]
io.rsocket.kotlin.RSocketCustomErrorTest ‑ shouldSuccessfullyCreate[js, browser, ChromeHeadless122.0.6261.69, Linuxx86_64]
io.rsocket.kotlin.core.RSocketTest ‑ requestChannelCancellationFromResponderShouldLeaveStreamInHalfClosedStateWithNextCompletionPossibleFromRequester[js, browser, ChromeHeadless122.0.6261.69, Linuxx86_64]
…
io.rsocket.kotlin.ConnectionEstablishmentTest ‑ requesterReleaseSetupPayloadOnFailedAcceptor[js, browser, ChromeHeadless123.0.6312.105, Linuxx86_64]
io.rsocket.kotlin.ConnectionEstablishmentTest ‑ responderRejectSetup[js, browser, ChromeHeadless123.0.6312.105, Linuxx86_64]
io.rsocket.kotlin.RSocketCustomErrorTest ‑ shouldFailBelowLowerBond[js, browser, ChromeHeadless123.0.6312.105, Linuxx86_64]
io.rsocket.kotlin.RSocketCustomErrorTest ‑ shouldFailOverUpperBond[js, browser, ChromeHeadless123.0.6312.105, Linuxx86_64]
io.rsocket.kotlin.RSocketCustomErrorTest ‑ shouldSuccessfullyCreateAtLowerBond[js, browser, ChromeHeadless123.0.6312.105, Linuxx86_64]
io.rsocket.kotlin.RSocketCustomErrorTest ‑ shouldSuccessfullyCreateAtUpperBond[js, browser, ChromeHeadless123.0.6312.105, Linuxx86_64]
io.rsocket.kotlin.RSocketCustomErrorTest ‑ shouldSuccessfullyCreateNearLowerBond[js, browser, ChromeHeadless123.0.6312.105, Linuxx86_64]
io.rsocket.kotlin.RSocketCustomErrorTest ‑ shouldSuccessfullyCreateNearUpperBond[js, browser, ChromeHeadless123.0.6312.105, Linuxx86_64]
io.rsocket.kotlin.RSocketCustomErrorTest ‑ shouldSuccessfullyCreate[js, browser, ChromeHeadless123.0.6312.105, Linuxx86_64]
io.rsocket.kotlin.core.RSocketTest ‑ requestChannelCancellationFromResponderShouldLeaveStreamInHalfClosedStateWithNextCompletionPossibleFromRequester[js, browser, ChromeHeadless123.0.6312.105, Linuxx86_64]
…
This pull request removes 9 skipped tests and adds 9 skipped tests. Note that renamed tests count towards both.
io.rsocket.kotlin.ConnectionEstablishmentTest ‑ responderRejectSetup[js, browser, ChromeHeadless122.0.6261.69, Linuxx86_64]
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestChannel16x256[js, browser, ChromeHeadless122.0.6261.69, Linuxx86_64]
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestChannel200000[js, browser, ChromeHeadless122.0.6261.69, Linuxx86_64]
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestChannel20000[js, browser, ChromeHeadless122.0.6261.69, Linuxx86_64]
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestChannel256x512[js, browser, ChromeHeadless122.0.6261.69, Linuxx86_64]
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestChannel500NoLeak[js, browser, ChromeHeadless122.0.6261.69, Linuxx86_64]
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestResponse100000[js, browser, ChromeHeadless122.0.6261.69, Linuxx86_64]
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestResponse10000[js, browser, ChromeHeadless122.0.6261.69, Linuxx86_64]
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestStream500NoLeak[js, browser, ChromeHeadless122.0.6261.69, Linuxx86_64]
io.rsocket.kotlin.ConnectionEstablishmentTest ‑ responderRejectSetup[js, browser, ChromeHeadless123.0.6312.105, Linuxx86_64]
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestChannel16x256[js, browser, ChromeHeadless123.0.6312.105, Linuxx86_64]
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestChannel200000[js, browser, ChromeHeadless123.0.6312.105, Linuxx86_64]
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestChannel20000[js, browser, ChromeHeadless123.0.6312.105, Linuxx86_64]
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestChannel256x512[js, browser, ChromeHeadless123.0.6312.105, Linuxx86_64]
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestChannel500NoLeak[js, browser, ChromeHeadless123.0.6312.105, Linuxx86_64]
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestResponse100000[js, browser, ChromeHeadless123.0.6312.105, Linuxx86_64]
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestResponse10000[js, browser, ChromeHeadless123.0.6312.105, Linuxx86_64]
io.rsocket.kotlin.transport.local.LocalTransportTest ‑ requestStream500NoLeak[js, browser, ChromeHeadless123.0.6312.105, Linuxx86_64]

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Mar 02 '24 09:03 github-actions[bot]