rsocket-js icon indicating copy to clipboard operation
rsocket-js copied to clipboard

Fix channel's payload.data deserialization in RSocketMachine

Open palamccc opened this issue 1 year ago • 0 comments

Motivation:

In the current RSocketMachine._handleRequestChannel implementation, the payload is deserialized twice. So it leads to deserialization error when channels are used with serializers in RSocketServer.

This bug only affects 'channel' interaction model, not other interaction models.

Modifications:

The bug and the fix are explained in the code comments. This PR only fixes the 0.x branch.

Result:

Added tests to test the deserialization and serialization path of the channel. Fixes https://github.com/rsocket/rsocket-js/issues/217

palamccc avatar Mar 31 '24 12:03 palamccc