rsocket-js icon indicating copy to clipboard operation
rsocket-js copied to clipboard

Published 20 hours ago • verified publisher icon rsocket

Set connection status to ERROR when closed due to protocol error (#126)

Open ada-waffles opened this issue 4 years ago • 2 comments

Set connection status to ERROR when closed due to protocol error

Motivation:

Addresses #126

Modifications:

  • Amends DuplexConnection#close to accept an optional error indicating that the connection is being closed due to that error
  • Updates implementations to handle this error and report it to consumers
  • Updates RSocketMachine to pass protocol-level connection errors to close
  • Adds/updates tests to check for handling this parameter

Result:

Protocol-level errors will forward the error through the new error parameter in DuplexConnection#close, resulting in ERROR status instead of CLOSED

ada-waffles avatar Apr 26 '21 02:04 ada-waffles

Hi @duke9509!

Thanks for filing #126 and for providing this PR. While I'm not able to offer a timeframe at the moment, we'll do our best to get this reviewed.

Thanks again!

viglucci avatar May 06 '21 02:05 viglucci

My questions were answered and everything turned out to be non-issues. I pinged some maintainers with write permissions to hopefully take a look and give a final approval/merge.

viglucci avatar May 15 '21 21:05 viglucci