rsocket-go icon indicating copy to clipboard operation
rsocket-go copied to clipboard

Implement custom mux for Websocket servers

Open anderspitman opened this issue 1 year ago • 2 comments

Implement custom mux for Websocket servers

Motivation:

I need to serve other HTTP content on the same mux as the websocket used by RSocket

Modifications:

Added a function for creating a WebsocketServerTransport with a mux passed in

Result:

Nothing broken, just added another function

anderspitman avatar Jan 22 '24 18:01 anderspitman

Note that I'm not sure this would be the best API for accomplishing this, but it was the easiest to get my code working. If this functionality is desired upstream I'm happy to implement it in another way pending a discussions of tradeoffs.

anderspitman avatar Jan 22 '24 18:01 anderspitman

Thanks for the PR :-) PS: Please fix the unit tests to prevent from CI failure, thanks.

jjeffcaii avatar Jan 28 '24 14:01 jjeffcaii