flutter_hooks
flutter_hooks copied to clipboard
add draggable_scrollable_controller
Added useDraggableScrollableController with tests
Didn't edit readme or changelog Lmk if you want the tests changed
I'd say this hook would benefit from the changes in https://github.com/rrousselGit/flutter_hooks/pull/415
Current implementation of useDraggableScrollableController is not disposing the DraggableScrollableController.
@davidmartos96 Good point! I copied this from Expandable tile controller. I forgot that that isn't disposed. I'll fix later
Fixed dispose issue If @rrousselGit plans on merging #415 I'll rebase and push
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.38%. Comparing base (
d53783b) to head (f4f8d62).
:exclamation: Current head f4f8d62 differs from pull request most recent head 47eaa1e
Please upload reports for the commit 47eaa1e to get more accurate results.
Additional details and impacted files
@@ Coverage Diff @@
## master #417 +/- ##
==========================================
+ Coverage 98.36% 98.38% +0.02%
==========================================
Files 21 22 +1
Lines 854 868 +14
==========================================
+ Hits 840 854 +14
Misses 14 14
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Done
⚠️ No Changeset found
Latest commit: d9cd970ef1714e7329c8c559ecd28c5fbc2ff467
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
LGTM thanks!