django-rq icon indicating copy to clipboard operation
django-rq copied to clipboard

[FIX] -- job status display in scheduler listing page template.

Open DhavalGojiya opened this issue 9 months ago • 6 comments
trafficstars

Fix job status display in scheduler template

Description

This PR updates scheduler.html to correctly display the job status by using job.get_status.value instead of job.get_status.

Changes

  • Updated job status display in scheduler.html.
  • Affects the scheduler view at /django-rq/schedulers/<scheduler_id>/.

Before Screenshot:

Before PR

After Screenshot:

After PR

Testing

  • Verified that the job status is displayed correctly in the scheduler view.
  • Ensured no other UI elements were affected.

DhavalGojiya avatar Feb 05 '25 17:02 DhavalGojiya

Hey @selwin,

Any updates on this? Does this fix require test cases? I don't think so, as it's just a template frontend-side value change.

DhavalGojiya avatar Mar 03 '25 09:03 DhavalGojiya

No tests is necessary since you provided a screenshot, but can you make sure that all tests pass?

selwin avatar Mar 03 '25 09:03 selwin

All tests on current master now pass. Try rebasing? CleanShot 2025-03-03 at 16 48 13

selwin avatar Mar 03 '25 09:03 selwin

All tests on current master now pass. Try rebasing? CleanShot 2025-03-03 at 16 48 13

Sure will do it today :)

EDIT: Done ✅

DhavalGojiya avatar Mar 03 '25 10:03 DhavalGojiya

@DhavalGojiya the tests still failed, did you look at the failing test to see what went wrong?

selwin avatar Mar 03 '25 11:03 selwin

@DhavalGojiya the tests still failed, did you look at the failing test to see what went wrong?

I think the issue is on GitHub Actions' side. The Docker pull image rate limit API has been exceeded, which is why the action is unable to run. IMG_20250303_234622

DhavalGojiya avatar Mar 03 '25 18:03 DhavalGojiya

@DhavalGojiya mind merging master into this branch so the tests can run again?

selwin avatar Jun 17 '25 00:06 selwin

@DhavalGojiya mind merging master into this branch so the tests can run again?

Rebase Done. Master to this Current Branch.

DhavalGojiya avatar Jun 17 '25 07:06 DhavalGojiya

Thanks!

selwin avatar Jun 17 '25 09:06 selwin