flow-coverage-report icon indicating copy to clipboard operation
flow-coverage-report copied to clipboard

Published 20 hours ago • verified publisher icon rpl

Propose to move react and react-dom to peerDependencies

Open Kudo opened this issue 8 years ago • 3 comments

Currently react and react-dom specified as dependencies in package.json. If user use next React version, e.g. React v16, there will have some unexpected dependencies in node_modules. Here to propose move them as peerDependencies.

Kudo avatar Jul 12 '17 08:07 Kudo

The dependencies will only be there for development builds though. If installing only production modules, as long as flow-coverage-report is listed as a devDepencency, it won't get installed.

IanVS avatar Oct 02 '17 17:10 IanVS

Any update here? It feels weird to have React 15 in our dependency graph, even if it's just a dev dependency.

swac avatar Oct 02 '18 16:10 swac

I noticed React 15 in the dependency graph as well today. Any ideas on how this can be solved?

NameFILIP avatar May 23 '22 20:05 NameFILIP