django-lock-tokens
django-lock-tokens copied to clipboard
feat: update template for django 3
Thanks for the PR, looks good!
Seems to me that it would break support of django < 1.10 though. But I guess it is not worth maintaining the package for those old versions. Just need to update the README.
Making plugin translatable is also a good idea!
Codecov Report
:exclamation: No coverage uploaded for pull request base (
master@a0c7933). Click here to learn what that means. The diff coverage is66.66%.
@@ Coverage Diff @@
## master #17 +/- ##
=========================================
Coverage ? 86.46%
=========================================
Files ? 16
Lines ? 399
Branches ? 25
=========================================
Hits ? 345
Misses ? 41
Partials ? 13
| Impacted Files | Coverage Δ | |
|---|---|---|
| lock_tokens/admin.py | 76.47% <66.66%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update a0c7933...f890b68. Read the comment docs.
Codecov Report
:exclamation: No coverage uploaded for pull request base (
master@a0c7933). Click here to learn what that means. The diff coverage is66.66%.
:exclamation: Current head f890b68 differs from pull request most recent head 1268d0e. Consider uploading reports for the commit 1268d0e to get more accurate results
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@ Coverage Diff @@
## master #17 +/- ##
=========================================
Coverage ? 86.46%
=========================================
Files ? 16
Lines ? 399
Branches ? 25
=========================================
Hits ? 345
Misses ? 41
Partials ? 13
| Impacted Files | Coverage Δ | |
|---|---|---|
| lock_tokens/admin.py | 76.47% <66.66%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@rparent can you give us an update on integrating this please? thx!