externis icon indicating copy to clipboard operation
externis copied to clipboard

Seems like the result display a wrong time

Open emmett2020 opened this issue 2 years ago • 1 comments

In this picture, it shows about 10 minutes. But the actual build time is less than 2seconds. Am I missed something? image

emmett2020 avatar Nov 09 '23 16:11 emmett2020

I think the time unit used here is wrong, I found the Wall Duration is 11688 s, while actually it takes about 11s, so should be divided by a 1000

TheodoreG avatar Apr 22 '24 07:04 TheodoreG

I think this is a bug in externis. According to https://docs.google.com/document/d/1CvAClvFfyA5R-PhYUmn5OOQtYMH4h6I0nSsKchNAySU/preview?tab=t.0 the ts has to be in microseconds but I think externis stores it in ns

dkuschmierzBosch avatar Jan 09 '25 15:01 dkuschmierzBosch

Huh. So I remembered I was a bit confused it. I do set "displayTimeUnit": "ns" in the JSON but the standard says it doesn't matter. Perfetto however used to understand it as the unit of measurement and this is where I took this idea from...

It was fixed a while ago already: https://android-review.googlesource.com/c/platform/external/perfetto/+/1888768 so it's probably time to fix this externis as well, let's see if I have time tonight.

royjacobson avatar Jan 09 '25 15:01 royjacobson

Fixed! Thanks for using externis :)

royjacobson avatar Jan 09 '25 18:01 royjacobson