rowy icon indicating copy to clipboard operation
rowy copied to clipboard

#513: Added Customizable Icons for Ratings Field

Open mshamsrainey opened this issue 3 years ago • 3 comments

#513: Added Customizable Icons for Rating Field

Demonstration here (no audio): https://www.loom.com/share/b4738b9a8a4e45e0bd9c945d9a203388 (Video demo updated to reflect side drawer and icon size updates)

Note: While working on this ticket, I encountered a bug that I created an issue for here #816. I also received some great design feedback that I wish I had time to work on, but don't think I will at the moment (at least during this one day open source challenge!).

mshamsrainey avatar Sep 16 '22 21:09 mshamsrainey

Hi @mshamsrainey, this looks great! in terms of the use of the preview fab icon button, it makes sense in the context of the action button, but here it would be more informative for the user to preview how the cell interaction is going to look

shamsmosowi avatar Sep 19 '22 13:09 shamsmosowi

@shamsmosowi great call, thanks for that feedback! I'll take a look at making that change either tonight or tomorrow and ping you for another review when I'm finished

mshamsrainey avatar Sep 19 '22 21:09 mshamsrainey

Hi @shamsmosowi, I just pushed a new commit changing the settings to give a preview of how the ratings will look using the custom icons.

While working on this, I also realized that the existing code would allow people to leave the text field indicating what they wanted their maximum rating to be blank, or set the maximum rating to something super high like 10,000. So, I added in some simple validation to restrict users to a range 1-20 based on the input props already present in the code.

Let me know what you think!

mshamsrainey avatar Sep 21 '22 12:09 mshamsrainey

@mshamsrainey is attempting to deploy a commit to the Rowy Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Sep 28 '22 17:09 vercel[bot]

@notsidney and @shamsmosowi just added those changes to improve contrast, let me know what you think! (@shamsmosowi I accidentally un-requested your review and now I'm not able to request it again, oops!)

mshamsrainey avatar Sep 28 '22 17:09 mshamsrainey

@mshamsrainey Thanks! I’m merging this now and it will be part of the next release 🚀

notsidney avatar Oct 03 '22 05:10 notsidney