rowy icon indicating copy to clipboard operation
rowy copied to clipboard

Logic issue in action field customized icons

Open mshamsrainey opened this issue 3 years ago • 1 comments

Toggling off customized icons in Actions field does not revert icons to default. Icons only revert to default when customized icon is removed from input field.

To Reproduce

  1. Create Actions field in table
  2. Open the configuration settings for the column with an actions field
  3. Click the checkbox to "Customize button icons with an emoji"
  4. Fill in an emoji of your choice to replace the default Run icon
  5. Save your changes and close the configuration
  6. Re-open the configuration settings for this column
  7. Un-check the checkbox to "Customize button icons with an emoji"
  8. Save changes and close configuration

Expected behavior Un-checking the checkbox for customized icons should revert icons back to default. Instead, the only way to revert icons to default is to remove them from the text field that appears after the customized icon checkbox is clicked.

Screenshots I felt that a video explained this better than an image, so I created a screen recording that you can access at this link

Desktop (please complete the following information):

  • OS: Windows
  • Browser: Chrome
  • Version: develop branch via localhost

Notes: I'm pretty sure this is a quick logic fix, just adding in a check for whether custom icons are enabled when determining the icon to show. I ran into this while working on #513, actually, and it was a one-line fix there. I can't imagine this being substantially more complex.

mshamsrainey avatar Sep 16 '22 20:09 mshamsrainey

I can go ahead and work on this actually! Just wanted to make it an issue in case anyone was looking for something to play around with :-) If someone could assign me that'd be great! (cc @harinij @shamsmosowi)

mshamsrainey avatar Sep 16 '22 23:09 mshamsrainey