rowy icon indicating copy to clipboard operation
rowy copied to clipboard

Notification showing on each click event

Open santoshgistto opened this issue 3 years ago • 7 comments
trafficstars

Rowy run setup notification showing on each click event Screen Shot 2022-03-20 at 11 18 50 PM To Reproduce Steps to reproduce the behavior:

  1. Don't setup rowy run
  2. Run application npm start
  3. click on menu items to multiple pages
  4. See error

Expected behavior Would be good if we show only per session and with close action icon.

santoshgistto avatar Mar 21 '22 03:03 santoshgistto

which version are you on? it should be fixed on v2.4

shamsmosowi avatar Mar 21 '22 04:03 shamsmosowi

i Have pulled main branch

santoshgistto avatar Mar 23 '22 04:03 santoshgistto

Hi @santoshgistto, I cannot reproduce this issue. Could you please check that the version you’re running is v2.4.0 or later in Project Settings? http://localhost:3000/settings/project

notsidney avatar Mar 28 '22 05:03 notsidney

@notsidney yes it is "version": "2.4.0",

santoshgistto avatar Mar 28 '22 18:03 santoshgistto

Hi @santoshgistto, the code that displays that snackbar was removed in commit cf10f9c and was released as part of v2.4.0. There is no other code that would display this snackbar.

I think what’s happening is that while you’ve pulled from the main branch, so your local clone is up to date at v2.4.0, your deployment of the web app is still running the previous version.

This is why I asked you to verify the version in the Project Settings page on the web app, and not the package.json value.

You need to re-deploy the app to your webhost or if you’re running a localhost dev server, restart it.

notsidney avatar Mar 30 '22 23:03 notsidney

@notsidney i have tried to reproduce but unfortunately app crashing with the following error

Failed to compile.

/react/rowy/src/components/TableHeader/CloudLogs/BuildLogs/index.tsx
TypeScript error in 
/react/rowy/src/components/TableHeader/CloudLogs/BuildLogs/index.tsx(136,24):
Property 'push' does not exist on type 'ReactNodeArray'.  TS2339
    134 | 
    135 |     if (diff !== prevDiff) {
  > 136 |       renderedLogItems.push(
        |                        ^
    137 |         <CloudLogSubheader key={`${diff} days ago`}>
    138 |           {diff === 0 ? "Today" : diff === 1 ? "Yesterday" : `${diff} days ago`}
    139 |         </CloudLogSubheader>

after taking update git pull

santoshgistto avatar Mar 31 '22 18:03 santoshgistto

It looks like an issue with the node modules installed in your local clone.

Try reinstalling dependencies using rm -rf node_modules; yarn then rebuilding.

If that doesn’t work, make a new clone of the repo.

notsidney avatar Mar 31 '22 23:03 notsidney