python-opengl icon indicating copy to clipboard operation
python-opengl copied to clipboard

Published 20 hours ago • verified publisher icon rougier

small error section 3.2.6 - Varying color

Open jabarragann opened this issue 5 years ago • 2 comments

Hi all,

I think there is an error on the fragment shader program of section 3.2.6. It should be using the previously declared variable "v_color" not "color"

image

jabarragann avatar Oct 04 '20 02:10 jabarragann

Just realized that #49 also pointed out the same mistake. However, when I tried to do the PR as you requested, I was not able to find the error on the source code. Both the book.html and the 03-quickstart.rst file don't have this error.

The error is only appearing in the book version in https://www.labri.fr/perso/nrougier/python-opengl/#varying-color.

So it might be fixed by uploading a newer version. (Not exactly sure of how to book is generated from source)

I can help you out doing the PR if you think there is any other file that needs to be changed.

jabarragann avatar Oct 04 '20 03:10 jabarragann

Thanks for the report. It may have been already corrected but the website is not up to date with GitHub soures (I have to built it manually).

rougier avatar Oct 12 '20 08:10 rougier