message_filters
message_filters copied to clipboard
Bugfix/segfault when getting surrounding interval of empty cache (backport #116)
This PR fixes a segfault that occurred to me when I tried to get a surrounding interval from a message_filter::Cache that was empty. See comment below for where/how.
The PR includes
- a test that should reproduce the segfault when executed without the fix.
- the fix of the segfault
Is it possible to get the fix also to other branches, specifically humble (but iron would probably also make sense)? That's the version I am using at the moment. I think the fix commit should be cherry-pickable. But the test commit probably needs some minor adaptation due to namespace changes.
Please let me know if I need to follow some specific procedure or provide more information for contributing (e.g. create issue first, or similar).
This is an automatic backport of pull request #116 done by Mergify.
Cherry-pick of e60450dabf1daf56642efe52fb790f8ecaacd9d7 has failed:
On branch mergify/bp/jazzy/pr-116
Your branch is up to date with 'origin/jazzy'.
You are currently cherry-picking commit e60450d.
(fix conflicts and run "git cherry-pick --continue")
(use "git cherry-pick --skip" to skip this patch)
(use "git cherry-pick --abort" to cancel the cherry-pick operation)
Changes to be committed:
modified: test/msg_cache_unittest.cpp
Unmerged paths:
(use "git add/rm <file>..." as appropriate to mark resolution)
deleted by us: include/message_filters/cache.hpp
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Pulls: ros2/message_filters#141 Gist: https://gist.githubusercontent.com/ahcorde/687e09a69528a23076713c47bcd2e244/raw/1dabb453e55675937303ecb65c7c153a94b7d44d/ros2.repos BUILD args: --packages-up-to message_filters --packages-above-and-dependencies message_filters TEST args: --packages-select message_filters --packages-above message_filters ROS Distro: jazzy Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14944