moveit2_tutorials icon indicating copy to clipboard operation
moveit2_tutorials copied to clipboard

Published 20 hours ago • verified publisher icon ros-planning

Perception tutorial missing some updates merged in (moveit1's) moveit_tutorials

Open 130s opened this issue 2 years ago • 4 comments

Description

Overview of your issue here.

For perception tutorial, I manually confirmed that the changes in these PRs are not included in moveit2_tutorials.

  • https://github.com/ros-planning/moveit_tutorials/pull/609,
  • https://github.com/ros-planning/moveit_tutorials/pull/627,
  • https://github.com/ros-planning/moveit_tutorials/pull/633,
  • https://github.com/ros-planning/moveit_tutorials/pull/672

Expected behaviour

  • I do not know if all the changes in the listed PRs are absolute necessity in ros2, esp. the perception tutorial hasn't yet been ported to ros2 (tracked in https://github.com/ros-planning/moveit2_tutorials/issues/583).
    • Which I'm trying to address in https://github.com/ros-planning/moveit2_tutorials/pull/700, including testing the changes in the listed PRs

130s avatar Jun 20 '23 19:06 130s

In https://github.com/ros-planning/moveit2_tutorials/pull/700 I manually cherry-picked the changes from the PRs listed in https://github.com/ros-planning/moveit2_tutorials/issues/708.

  • Changes from each PR is committed separately for the better visibility.
  • Initially I tried to git cherry-pick those changes, but some PRs included changes outside of perception tutorial, which is not my scope of the PR, so I gave up and went ahead manually applying changes.

130s avatar Jun 22 '23 20:06 130s

Resolution to this is now ready for review in https://github.com/ros-planning/moveit2_tutorials/pull/700

130s avatar Jun 29 '23 14:06 130s

Closing as I think https://github.com/moveit/moveit2_tutorials/pull/906 addresses this.

130s avatar Aug 20 '24 20:08 130s

Sorry I closed a wrong ticket. Reopening.

130s avatar Aug 20 '24 20:08 130s