moveit2 icon indicating copy to clipboard operation
moveit2 copied to clipboard

Add python binding for LinkModel

Open JafarAbdi opened this issue 2 years ago • 5 comments

Description

This's initial python binding for link model, right now I only added the functions I needed :D

The second commit adds support for creating a robot model using urdf/srdf strings, this make it easier to create one given MoveItConfigs

Checklist

  • [ ] Required by CI: Code is auto formatted using clang-format
  • [ ] Extend the tutorials / documentation reference
  • [ ] Document API changes relevant to the user in the MIGRATION.md notes
  • [ ] Create tests, which fail without this PR reference
  • [ ] Include a screenshot if changing a GUI
  • [ ] While waiting for someone to review your request, please help review another open pull request to support the maintainers

JafarAbdi avatar Jun 22 '23 22:06 JafarAbdi

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (636b988) 50.50% compared to head (bc80b58) 50.52%. Report is 148 commits behind head on main.

Files Patch % Lines
...src/moveit/moveit_core/robot_model/robot_model.cpp 89.48% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2247      +/-   ##
==========================================
+ Coverage   50.50%   50.52%   +0.02%     
==========================================
  Files         386      387       +1     
  Lines       31731    31745      +14     
==========================================
+ Hits        16022    16035      +13     
- Misses      15709    15710       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 22 '23 22:06 codecov[bot]

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

github-actions[bot] avatar Oct 02 '23 12:10 github-actions[bot]

This pull request is in conflict. Could you fix it @JafarAbdi?

mergify[bot] avatar Oct 27 '23 14:10 mergify[bot]

Apologies for not following up on this for so long and thanks for adding these changes @JafarAbdi. I believe some refactor is required based on updates made to the library but otherwise this LGTM.

peterdavidfagan avatar Oct 30 '23 15:10 peterdavidfagan

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

github-actions[bot] avatar Jan 19 '24 12:01 github-actions[bot]