navigation2 icon indicating copy to clipboard operation
navigation2 copied to clipboard

modified slam_launch file for the issue #4202

Open iOzcan1 opened this issue 1 year ago • 2 comments


Basic Info

Info modified slam_launch file in nav2_bringup package because of the this issue: cloned_multi_tb3_simulation, slam:=true does not create maps #4202
Ticket(s) this addresses #4202
Primary OS tested on Ubuntu 22.04
Robotic platform tested on turtlebot3 in gazebo
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

I simply added remappings for the topics slam_toolbox node subs/pubs.

Description of documentation updates required from your changes

Nothing has to be changed because now it works according to the documentation. Previously it was not functioning as it is intended that is having multi robots doing their own slam.


Future work that may be required in bullet points

For Maintainers:

  • [ ] Check that any new parameters added are updated in navigation.ros.org
  • [ ] Check that any significant change is added to the migration guide
  • [ ] Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • [ ] Check that any new functions have Doxygen added
  • [ ] Check that any new features have test coverage
  • [ ] Check that any new plugins is added to the plugins page
  • [ ] If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

iOzcan1 avatar Mar 23 '24 21:03 iOzcan1

@iOzcan1, all pull requests must be targeted towards the main development branch. Once merged into main, it is possible to backport to @humble, but it must be in main to have these changes reflected into new distributions.

mergify[bot] avatar Mar 23 '24 21:03 mergify[bot]

@iOzcan1 all PRs need to target the main branch so that they are included in the current SOTA and released into new distributions

SteveMacenski avatar Mar 25 '24 20:03 SteveMacenski

This pull request is in conflict. Could you fix it @iOzcan1?

mergify[bot] avatar Apr 11 '24 19:04 mergify[bot]

@iOzcan1, your PR has failed to build. Please check CI outputs and resolve issues. You may need to rebase or pull in main due to API changes (or your contribution genuinely fails).

mergify[bot] avatar Apr 11 '24 19:04 mergify[bot]

Hey @SteveMacenski . I followed your comments. Now, there is a new PR. I created myBranch from main to do necessary changes, committed and pushed back, and it automatically created a new PR. I hope I did it correctly this time. I assume this PR is not relevant anymore.

iOzcan1 avatar Apr 11 '24 20:04 iOzcan1

Correct, it also has conflicts up the wazoo + touches 38k lines :laughing:

SteveMacenski avatar Apr 11 '24 22:04 SteveMacenski