control_toolbox icon indicating copy to clipboard operation
control_toolbox copied to clipboard

Exponantial filter refactoring

Open silanus23 opened this issue 2 months ago • 3 comments

I have tried to solve the issue on #365. Tried to go with the way of low_pass_filter:

  • Added support both std::vector<double> and geometry_msgs::msg::WrenchStamped.
  • Created a header in control_toolbox and making it use control_filters header.
  • Expanded tests in a way that it tests all data types and their results in the new style.

silanus23 avatar Sep 29 '25 08:09 silanus23

Codecov Report

:x: Patch coverage is 93.45794% with 7 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 83.85%. Comparing base (18c4b12) to head (504c855).

Files with missing lines Patch % Lines
...box/include/control_toolbox/exponential_filter.hpp 76.19% 2 Missing and 3 partials :warning:
...box/include/control_filters/exponential_filter.hpp 60.00% 1 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #493      +/-   ##
==========================================
+ Coverage   83.13%   83.85%   +0.71%     
==========================================
  Files          29       30       +1     
  Lines        1981     2094     +113     
  Branches      110      112       +2     
==========================================
+ Hits         1647     1756     +109     
  Misses        268      268              
- Partials       66       70       +4     
Flag Coverage Δ
unittests 83.85% <93.45%> (+0.71%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...x/test/control_filters/test_exponential_filter.cpp 100.00% <100.00%> (ø)
...box/include/control_filters/exponential_filter.hpp 65.00% <60.00%> (-1.67%) :arrow_down:
...box/include/control_toolbox/exponential_filter.hpp 76.19% <76.19%> (ø)

... and 1 file with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Oct 01 '25 12:10 codecov-commenter

@christophfroehlich Sorry for late response uncontrollabe delay. I copied the low_pass_filter structure. Seems like those specializations are unnecessary . Thanks for the review!

silanus23 avatar Oct 25 '25 14:10 silanus23

no worries, thanks for coming back on this. I have removed the specialization in the master branch already, have a look.

christophfroehlich avatar Oct 25 '25 14:10 christophfroehlich

@silanus23 what do you think about my last comment? can we go on with this PR?

christophfroehlich avatar Nov 09 '25 08:11 christophfroehlich

@christophfroehlich I am going to try them but couldn't find time now. Won't take long to come back I guess.

silanus23 avatar Nov 09 '25 15:11 silanus23

@christophfroehlich sorry for late update. I had to include that cause it didn't compile otherwise.

silanus23 avatar Nov 10 '25 16:11 silanus23