control_toolbox
control_toolbox copied to clipboard
Exponantial filter refactoring
I have tried to solve the issue on #365. Tried to go with the way of low_pass_filter:
- Added support both
std::vector<double>andgeometry_msgs::msg::WrenchStamped. - Created a header in
control_toolboxand making it usecontrol_filtersheader. - Expanded tests in a way that it tests all data types and their results in the new style.
Codecov Report
:x: Patch coverage is 93.45794% with 7 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 83.85%. Comparing base (18c4b12) to head (504c855).
Additional details and impacted files
@@ Coverage Diff @@
## master #493 +/- ##
==========================================
+ Coverage 83.13% 83.85% +0.71%
==========================================
Files 29 30 +1
Lines 1981 2094 +113
Branches 110 112 +2
==========================================
+ Hits 1647 1756 +109
Misses 268 268
- Partials 66 70 +4
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 83.85% <93.45%> (+0.71%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Files with missing lines | Coverage Δ | |
|---|---|---|
| ...x/test/control_filters/test_exponential_filter.cpp | 100.00% <100.00%> (ø) |
|
| ...box/include/control_filters/exponential_filter.hpp | 65.00% <60.00%> (-1.67%) |
:arrow_down: |
| ...box/include/control_toolbox/exponential_filter.hpp | 76.19% <76.19%> (ø) |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@christophfroehlich Sorry for late response uncontrollabe delay. I copied the low_pass_filter structure. Seems like those specializations are unnecessary . Thanks for the review!
no worries, thanks for coming back on this. I have removed the specialization in the master branch already, have a look.
@silanus23 what do you think about my last comment? can we go on with this PR?
@christophfroehlich I am going to try them but couldn't find time now. Won't take long to come back I guess.
@christophfroehlich sorry for late update. I had to include that cause it didn't compile otherwise.