control_toolbox
control_toolbox copied to clipboard
ros-controls
- The very first line in the readme of the ros2-master branch points to non-ROS 2 docs - Maybe add/link some demos as proposed in #70. I know that one...
Closes #164. Test passes locally. The old `LowPassFilter` class is now `LowPassFilterRos`. API-breaking since with this patch `LowPassFilter` is a parent class without ROS parameters. @christophfroehlich at least for now...
Saves integral term on reset to maintain steady state offset output. This is required for controlling of system without integral part to achieve correct steady-state output. If intergral term is...
I wanted to use `LowPassFilter`, but it seems to me that there is no way to pass parameters via API (like `PID` constructor or `setGains()` call). Wouldn't be better to...
``` | [Processing: control_toolbox] | --- stderr: control_toolbox | Errors while running CTest | Output from these tests are in: /home/christoph/projects/ros2_rolling_ws/src/control_toolbox/build/control_toolbox/Testing/Temporary/LastTest.log | Use "--rerun-failed --output-on-failure" to re-run the failed cases...
This is a rework of PR https://github.com/ros-controls/control_toolbox/pull/115 for the gravity-compensation filter part, now using generate_parameter_library.
Unless the filter_base is changed, I don't think the filter has any access to the node (only its logger and parameter interfaces). Maybe the filter should get a time and...
https://github.com/ros-controls/control_toolbox/pull/129#pullrequestreview-1371661251
When we add other filters often used in controllers, we should also move `exponentialSmoothing` in a filter to make its use clearer. https://github.com/ros-controls/control_toolbox/blob/29190b4acab8c62c9e1787310674aa739f6ff93c/include/control_toolbox/filters.hpp#L51
Generally agree with this changes! I would open as followup an issue about renaming `topic_prefix_` because its name is misleading, `parameter_perfix_` would be more suitable. _Originally posted by @destogl in...