charlatan
charlatan copied to clipboard
Person providers remove duplicate names and sort name vectors
- I've seen duplicate names in the person-providers that I've worked with, e.g. fr_FR had "Margot" twice in the first_name_female vector. I can imagine there are duplicate names in other locales. A thorough sweep should be performed on all locales.
- All name vectors in all locales should be sorted alphabetically (for cleanliness). Many of the vectors already are. But a sweep should be performed.
👍 agree, thanks
I think this can be closed because my PR https://github.com/ropensci/charlatan/pull/96 should solve this.
thanks will have a look
thanks @MartinMSPedersen - but we should probably check the other person provider files before closing this