charlatan icon indicating copy to clipboard operation
charlatan copied to clipboard

Person providers remove duplicate names and sort name vectors

Open kylevoyto opened this issue 7 years ago • 4 comments

  • I've seen duplicate names in the person-providers that I've worked with, e.g. fr_FR had "Margot" twice in the first_name_female vector. I can imagine there are duplicate names in other locales. A thorough sweep should be performed on all locales.
  • All name vectors in all locales should be sorted alphabetically (for cleanliness). Many of the vectors already are. But a sweep should be performed.

kylevoyto avatar Jul 31 '18 00:07 kylevoyto

👍 agree, thanks

sckott avatar Jul 31 '18 05:07 sckott

I think this can be closed because my PR https://github.com/ropensci/charlatan/pull/96 should solve this.

MartinMSPedersen avatar Oct 05 '18 07:10 MartinMSPedersen

thanks will have a look

sckott avatar Oct 05 '18 19:10 sckott

thanks @MartinMSPedersen - but we should probably check the other person provider files before closing this

sckott avatar Oct 05 '18 22:10 sckott