create-expo-stack
create-expo-stack copied to clipboard
roninoss
[cli] Add Clerk auth support
Description
Just adding support for Clerk authentication (https://clerk.com/) as I use it a lot and would be nice to have as part of my project scaffold.
Related Issue
N/A
Motivation and Context
The motivation behind this change is so that people have a baseline project start option for using Clerk as an authentication basis.
How Has This Been Tested?
- Added a test for the mainstream popular line (clerk, expo-router, nativewind)
- Manually tested each variation that included clerk (thank goodness for the do you want to delete existing project cli step)
Screenshots (if appropriate):
N/A
@jan-vdm is this ready for review? if so, can you request Danny review it?
@jan-vdm is this ready for review? if so, can you request Danny review it?
It is ready but I don't have the ability to add reviewers unfortunately
@dannyhw bumping in case this slipped. I'll have time later this week to review if you're busy.
Hey, sorry it's been a busy week haven't gotten around to it yet. I can take a look now.
@jan-vdm thanks for taking the time to put this together first of all. And sorry I wasn't able to get to this sooner.
I have just tested this and it seems to be working, just one thing I want to ask
in clerks guide they suggest using expo-secure-store to configure the Token Cache, shouldn't we also add this to the setup here? Are there reasons to not add it?
@jan-vdm thanks for taking the time to put this together first of all. And sorry I wasn't able to get to this sooner.
I have just tested this and it seems to be working, just one thing I want to ask
in clerks guide they suggest using expo-secure-store to configure the Token Cache, shouldn't we also add this to the setup here? Are there reasons to not add it?
I mean I'm more than happy to add that in, didn't know how opinionated we wanted to go as you could use something else as the token cache. But I guess they could remove the dependency themself if that's the case.
Personally I think we should be pretty opinionated and expo secure store would be the right choice from what I can tell.
@dannyhw added the expo-secure-store to the template, haven't been able to test it though as I have a newborn hence why I've taken a while with this. Feel free to take it for a spin otherwise I'll test it when I next get time.
hey @jan-vdm just checking in if you'll have time to revisit any time soon?
@dannyhw we should probably move to rebase and/or test ourselves. Will you have time this week to do so? If not, I can see if I will.
@danstepanov unfortunately a lot going on at work for me currently so not sure I will have time. I didn't get around to the src folder stuff for the same reason, sorry about that.