create-expo-stack icon indicating copy to clipboard operation
create-expo-stack copied to clipboard

feat: eas flag for dev client setup

Open dannyhw opened this issue 1 year ago • 5 comments

Description

Aims to add an option for initialising a project with eas

Related Issue

Motivation and Context

Simpler eas setup

How Has This Been Tested?

Screenshots (if appropriate):

https://github.com/danstepanov/create-expo-stack/assets/3481514/fc722af9-b888-4679-ae0a-a2202d28fc38

dannyhw avatar Apr 19 '24 23:04 dannyhw

🦋 Changeset detected

Latest commit: 402ee2540efa866c98ade721273e8f65a1c17df1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-expo-stack Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Apr 19 '24 23:04 changeset-bot[bot]

@dannyhw is attempting to deploy a commit to the ronin-tech Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Apr 19 '24 23:04 vercel[bot]

I think potentially we could run prebuild for the user which would also get them to configure the bundle identifiers and generate the ios/android folders. The only reason I didn't add it is because you could probably get by with just letting eas generate those on the cloud.

dannyhw avatar Apr 23 '24 22:04 dannyhw

@dannyhw is this ready for review based on our last discussion?

danstepanov avatar Apr 30 '24 20:04 danstepanov

@danstepanov hey, had a really busy week so haven't had a chance to iterate on it since then. There's a few changes I'd like to make still.

dannyhw avatar Apr 30 '24 22:04 dannyhw

@danstepanov Hey sorry for the delay I had a lot going on. Made some updates based on what we spoke about.

dannyhw avatar May 06 '24 00:05 dannyhw

@dannyhw Can you make this part of the core CLI questions? Not just a flag.

danstepanov avatar May 14 '24 18:05 danstepanov

Hey @danstepanov, it should come up as a question already. I made it a flag more because I wasn't sure if it fit as a "package".

dannyhw avatar May 14 '24 19:05 dannyhw

@dannyhw mind rebasing with main? I'll merge and take it from there :)

danstepanov avatar May 15 '24 20:05 danstepanov

@danstepanov merged in changes and conflicts resolved 👍

dannyhw avatar May 15 '24 21:05 dannyhw