tools icon indicating copy to clipboard operation
tools copied to clipboard

feat(rome_js_analyze): noPrecisionLoss

Open 95th opened this issue 3 years ago • 5 comments

Summary

Implement eslint's no-loss-of-precision lint.

Test Plan

Added unit tests.

95th avatar Nov 16 '22 02:11 95th

Deploy Preview for docs-rometools ready!

Built without sensitive environment variables

Name Link
Latest commit 7a2d33a6fd83df0cf5d2b6558620cd1b302a9410
Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/637680c50268750008ed3112
Deploy Preview https://deploy-preview-3756--docs-rometools.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Nov 16 '22 02:11 netlify[bot]

!bench_analyzer

MichaReiser avatar Nov 16 '22 09:11 MichaReiser

Analyzer Benchmark Results

group                     main                                   pr
-----                     ----                                   --
analyzer/css.js           1.00      2.6±0.09ms     4.4 MB/sec    1.04      2.7±0.15ms     4.2 MB/sec
analyzer/index.js         1.00      7.5±0.32ms     4.4 MB/sec    1.03      7.7±0.29ms     4.3 MB/sec
analyzer/lint.ts          1.00      3.6±0.10ms    11.5 MB/sec    1.03      3.7±0.09ms    11.2 MB/sec
analyzer/parser.ts        1.00      8.7±0.35ms     5.6 MB/sec    1.02      8.9±0.39ms     5.5 MB/sec
analyzer/router.ts        1.00      6.0±0.16ms    10.2 MB/sec    1.04      6.2±0.19ms     9.8 MB/sec
analyzer/statement.ts     1.00      8.4±0.27ms     4.2 MB/sec    1.05      8.9±0.33ms     4.0 MB/sec
analyzer/typescript.ts    1.00     13.0±0.49ms     4.2 MB/sec    1.01     13.2±0.53ms     4.1 MB/sec

github-actions[bot] avatar Nov 16 '22 09:11 github-actions[bot]

@95th there's a formatting issue that prevents me from merging the PR.

MichaReiser avatar Nov 17 '22 12:11 MichaReiser

@MichaReiser Fixed now.

95th avatar Nov 17 '22 14:11 95th