plugins icon indicating copy to clipboard operation
plugins copied to clipboard
verified publisher icon rollup

Update resolve-require-sources.js

Open zhennann opened this issue 2 months ago • 1 comments

rollupContext.getModuleInfo(dependencyId) maybe undefined when isWrappedCommonJS is true for node:xxx module

Rollup Plugin Name: @rollup/plugin-commonjs

This PR contains:

  • [x] bugfix
  • [ ] feature
  • [ ] refactor
  • [ ] documentation
  • [ ] other

Are tests included?

  • [ ] yes (bugfixes and features will not be merged without tests)
  • [x] no

Breaking Changes?

  • [ ] yes (breaking changes will not be merged unless absolutely necessary)
  • [x] no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

zhennann avatar Oct 15 '25 08:10 zhennann

@zhennann thanks for the PR. as the template states, we need a test for this to both demonstrate the issue and prevent regressions. we cannot merge this without a test.

shellscape avatar Oct 15 '25 15:10 shellscape