plugins icon indicating copy to clipboard operation
plugins copied to clipboard
verified publisher icon rollup

refactor(pluginutils): use pathe to support browser environments

Open zhiyuanzmj opened this issue 11 months ago • 2 comments

Rollup Plugin Name: pluginutils

This PR contains:

  • [ ] bugfix
  • [ ] feature
  • [x] refactor
  • [ ] documentation
  • [ ] other

Are tests included?

  • [ ] yes (bugfixes and features will not be merged without tests)
  • [x] no

Breaking Changes?

  • [ ] yes (breaking changes will not be merged unless absolutely necessary)
  • [x] no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

Uses pathe instead of Node's native path module to support browser environments

zhiyuanzmj avatar Jan 17 '25 07:01 zhiyuanzmj

Without discussion on why this is needed, I'm not inclined to approve this. Why not just alias path to pathe within bundler configuration?

shellscape avatar Mar 06 '25 15:03 shellscape

Thanks for your reply.

I created a REPL supports rollup plugins, but when plugin are using createFilter that's will be don't support browser. https://repl.zmjs.dev/vue-macros/vue-jsx-vapor

No matter, this maybe not a popular demand. you can close it at will.

zhiyuanzmj avatar Mar 06 '25 15:03 zhiyuanzmj

Yes I think a fork here would be more appropriate. Thank you for the PR none the less.

shellscape avatar Jun 17 '25 13:06 shellscape