plugins icon indicating copy to clipboard operation
plugins copied to clipboard

fix(estree-walker): bump estree-walker to v3

Open bashmish opened this issue 1 year ago • 3 comments

Rollup Plugin Name: commonjs, dynamic-import-vars, inject, pluginutils, strip

This PR contains:

  • [ ] bugfix
  • [ ] feature
  • [ ] refactor
  • [ ] documentation
  • [x] other

Are tests included?

  • [ ] yes (bugfixes and features will not be merged without tests)
  • [x] no

Breaking Changes?

  • [ ] yes (breaking changes will not be merged unless absolutely necessary)
  • [x] no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers: none

Description

  • estree-walker has been updated to v3 which is an ESM package
  • I'm using v3, it works best with my TypeScript setup with ESM everywhere and JSDoc syntax for types
  • the goal here is to update it across all tooling and minimize dependecies/duplicates

bashmish avatar Oct 14 '24 09:10 bashmish

Thanks for the PR. Looks like this change set causes issues with CI. Please have a look.

shellscape avatar Oct 16 '24 02:10 shellscape

This is puzzling me. I tried this locally in different ways, not only with pnpm install --frozen-lockfile, but also separately for the package in question, all works fine.

I also used the same pnpm as in the Actions npm i -g [email protected], no luck.

Looks like @types/estree dependency is not deduped optimally and hence I tried to fix manually the lock file, but I can't test this locally, I mean it works before and after. And running the build here requires a manual approve, so my test loop is very long (last time it was a day), not sure how to proceed, just hope it works this time in Actions.

bashmish avatar Oct 21 '24 15:10 bashmish

I figured pnpm --recursive build gives this error. Can test locally now 🎉

bashmish avatar Oct 21 '24 15:10 bashmish

closing as abandoned

shellscape avatar Oct 28 '25 01:10 shellscape