plugins icon indicating copy to clipboard operation
plugins copied to clipboard
verified publisher icon rollup

chore(node-resolve): remove is-builtin-module

Open 43081j opened this issue 1 year ago • 2 comments

Node has shipped builtinModules for some time now, so we no longer need a third party package to do this.

Once the engines constraint is bumped in the package.json, we can also move to using the built-in isBuiltin function (available since 16.x).

Rollup Plugin Name: node-resolve

This PR contains:

  • [ ] bugfix
  • [ ] feature
  • [x] refactor
  • [ ] documentation
  • [ ] other

Are tests included?

  • [ ] yes (bugfixes and features will not be merged without tests)
  • [x] no (existing tests should cover it)

Breaking Changes?

  • [ ] yes (breaking changes will not be merged unless absolutely necessary)
  • [x] no

43081j avatar Jun 07 '24 21:06 43081j

FYI the engine constraint in here actually specifies 14 or something. Which is why I have used the built in modules list (available in 14), but not isBuiltin (available in 16)

Just to be clear

If we can bump the engine constraint to 16, we could use the built in function

43081j avatar Jun 07 '24 22:06 43081j

any chance we can get this merged? 👀

would be a good to pull it into a few dependents

43081j avatar Jun 18 '24 18:06 43081j

@shellscape any chance you can take a look at this? would be good to close it off

43081j avatar Aug 29 '24 12:08 43081j

any possibility of a review from someone here? would be super nice to merge this so it doesn't get left behind

43081j avatar Sep 07 '24 07:09 43081j

thanks!

shellscape avatar Sep 22 '24 23:09 shellscape