plugins icon indicating copy to clipboard operation
plugins copied to clipboard

Resolve issue #1652 - Typescript plugin fails to compile the entry point when there is at least one invalid TypeScript file somewhere is the working directory

Open ericmorand opened this issue 2 years ago • 1 comments

Rollup Plugin Name: typescript

This PR contains:

  • [x] bugfix
  • [ ] feature
  • [ ] refactor
  • [ ] documentation
  • [ ] other

Are tests included?

  • [x] yes (bugfixes and features will not be merged without tests)
  • [ ] no

Breaking Changes?

  • [ ] yes (breaking changes will not be merged unless absolutely necessary)
  • [x] no

List any relevant issue numbers:

  • resolves #1652

Description

This PR solves the issue described in #1652. It focuses on not creating a breaking changes by ensuring that no existing test was modified - except one that I'd like to discuss with the maintainers.

Basically, what this PR does is to remove the initial emit of all the files included in th working directory and instead emit files that are part of the dependency graph of the entry point.

ericmorand avatar Dec 16 '23 22:12 ericmorand

Apologies for the delay. We always have a shortage of maintainers for this repo, and it doesn't look like anyone else has stepped in to review this. Best I can do is give them another ping.

shellscape avatar Dec 15 '24 16:12 shellscape