rollbar-php-laravel icon indicating copy to clipboard operation
rollbar-php-laravel copied to clipboard

Missing session data

Open Lukasz93P opened this issue 4 years ago • 5 comments

Hi - https://github.com/rollbar/rollbar-php-laravel/pull/108 I have added one new comment - error which was supposed to be resolved is still there.

Lukasz93P avatar Oct 12 '21 06:10 Lukasz93P

Is anybody there?

Lukasz93P avatar Oct 28 '21 09:10 Lukasz93P

Hi @Lukasz93P

Thanks for reporting it.

For clarification, here's an exception you mentioned in #108: Attempt to read property "session" on null (Most recent call first) - /app/vendor/rollbar/rollbar-laravel/src/MonologHandler.php line 62

I believe this error occurs due to breaking changes in Lumen 8.x. I've just merged #106 which addresses this issue. Would you mind trying the #106 PR (or master branch) to see if this works for you?

bxsx avatar Nov 02 '21 20:11 bxsx

OK @bxsx thanks, give me a few days, I will check if it works for me.

Lukasz93P avatar Nov 04 '21 14:11 Lukasz93P

@bxsx yes it works, but with this solution data is not complete - just look at screen. Screenshot 2021-11-05 at 22 43 33

Why you are so stubborn with not using solution which I have proposed It solves everything, instead of using something which works you gave me second not complete solution...

Lukasz93P avatar Nov 05 '21 21:11 Lukasz93P

Thanks for the info @Lukasz93P It seems PR #106 has fixed the reported issue, but now we have a new problem.

Your PR #108 seems to fix this, therefore we are going to re-review it now.

bxsx avatar Nov 09 '21 13:11 bxsx