rollbar-gem icon indicating copy to clipboard operation
rollbar-gem copied to clipboard

Rethink the deploy timeout

Open ArturMoczulski opened this issue 6 years ago • 2 comments

Related to https://github.com/rollbar/rollbar-gem/issues/853

We need to rethink our strategy around how we deal with timeout issues in deploy tracking

ArturMoczulski avatar Apr 02 '19 22:04 ArturMoczulski

Currently, the timeout is set to 60 seconds which IMHO is definitely too short. I'd suggest to bump it to at least 5 minutes

ArturMoczulski avatar Apr 18 '19 01:04 ArturMoczulski

We also need to improve the error message. The message that customers get when the deploy times out is not helpful:

`** Setting deployment status to "succeeded" in Rollbar

  • #<URI::HTTPS https://api.rollbar.com/api/1/deploy/11820877?access_token=a61817f197a341adb5d368c2192cda04>: {"status":"succeeded","comment":null}
  • 403; Forbidden; { "err": 1, "message": "The deploy can not be updated because its status is not started."}`

https://app.intercom.io/a/apps/rlisg82q/inbox/inbox/849049/conversations/21465780235

letaniaferreira avatar Apr 19 '19 17:04 letaniaferreira