rollbar-gem icon indicating copy to clipboard operation
rollbar-gem copied to clipboard

Rollbar Gem Docs out of date

Open matthewtusker opened this issue 1 year ago • 4 comments

The Rollbar Gem configuration reference mentions that girl_friday is used when use_async is set to true. From the looks of the Gem girl_friday was replaced with sucker_punch (possibly 10+ years ago???). Can the configuration reference be updated to reflect this?

matthewtusker avatar Sep 09 '24 09:09 matthewtusker

@matthewtusker , thank you for the report.

Rollbar-gem does still use girl_friday by default if it is present. https://github.com/rollbar/rollbar-gem/blob/master/lib/rollbar/notifier.rb#L859-L863

The default when it isn't present is Thread, which is probably the best default going forward. Until this is changed in Rollbar-gem, the current doc is accurate.

waltjones avatar Sep 09 '24 14:09 waltjones

Reopening to change the default in next major version (v4).

waltjones avatar Sep 09 '24 14:09 waltjones

Ah, I hadn't found that in the codebase, I had just read through the gemspec and couldn't find a reference to it. I had assumed that it had been dropped since the last release was 11 years ago (January 2013).

matthewtusker avatar Sep 10 '24 08:09 matthewtusker