rollbar-gem
rollbar-gem copied to clipboard
scope does not like false
Steps to reproduce:
Try to add some scope with a false value:
Rollbar.scoped(example: false) { Rollbar.error(Exception.new) }
Observed:
- the
examplekey does not appear on the exception - If you use any other truthy value (including
true, numbers, or anthing else other thannil) it sends correctely
Desired:
falseandtrueare treated the same way. Maybenilis different?
Notes:
- The behavior comes from this line - that condition is falsy with
falseornilso nothing is done - Maybe the behavior of
falseandnilshould be thought about here? To mefalseshould be merged in like a normal value andnilindicates that we want to remove that value in the merged hash. But maybe others feel differently?