rollbar-gem icon indicating copy to clipboard operation
rollbar-gem copied to clipboard

Option to enable scoped block for DelayedJob plugin

Open iangreenleaf opened this issue 3 years ago • 0 comments

Description of the change

Adds a new configuration option to run DelayedJob invocations in a scoped block. When enabled, this adds job data to any Rollbar reporting that happens within the job, and prevents changes to the scope (like calling scope! within a job) from polluting the global scope for other jobs.

I noticed that the Sidekiq plugin had an option for this (#1038) so I followed that format.

Type of change

  • [ ] Bug fix (non-breaking change that fixes an issue)
  • [x] New feature (non-breaking change that adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Maintenance
  • [ ] New release

Related issues

  • #1036
  • #1038

Checklists

Development

  • [x] Lint rules pass locally
  • [x] The code changed/added as part of this pull request has been covered with tests
  • [x] All tests related to the changed code pass in development

Code review

  • [ ] This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • [ ] "Ready for review" label attached to the PR and reviewers assigned
  • [ ] Issue from task tracker has a link to this pull request
  • [ ] Changes have been reviewed by at least one other engineer

iangreenleaf avatar Feb 28 '22 22:02 iangreenleaf