Rohit Gupta

Results 47 comments of Rohit Gupta

closing in favor of #14185

@otaj it's done. Any things else needs to be done here? The CI is blocking the merge for now

> I wonder if the introduced plugin should be marked as protected for that reason. I don't think so since users should have access to all kinds of plugins we...

hey @H-Sorkatti ! can you try the recent release?

then, I'd also suggest trying with @awaelchli mentioned.

> Accept to unblock, but I disagree with it the same way I disagreed when the on_before and on_after hooks were originally introduced. > on_before_batch_transfer has no meaning when the...

weird! why is it running this job? `Check Docs / make-docs (app) (pull_request)`

I don't understand. This PR is not touching the app code, and app docs are failing (required) here but not on master. This is blocking the merge here.