BBB-AWS-S3 icon indicating copy to clipboard operation
BBB-AWS-S3 copied to clipboard

Is this compatible with greenlight?

Open jnar opened this issue 5 years ago • 10 comments

Hello.

I have an issue after meeting is processed and presentation is uploaded button "Presentation" shows in greenlight but then after some minutes its gone, link works but is not displaying in gl.

Any clue on what can I do ?

jnar avatar Aug 07 '20 00:08 jnar

Ok now checking with bbb-record --watch I see that only shows "podcast,screenshare" but not presentation so question is not about greenlight but about bbb

jnar avatar Aug 07 '20 00:08 jnar

What is the value of DELETE_SERVER_FILES ? on Line 6 in your edited code of bbb-s3.py

is it set to True?

rohitcoder avatar Aug 07 '20 02:08 rohitcoder

Yes, I have set to true that value

jnar avatar Aug 07 '20 03:08 jnar

Just set Value to False and then check if everything works properly.

I never checked it with GreenLight but it seems, greenlight only shows those records whose folders are present in bbb instance.

Just set value to false and try again, it will do everything same as this script is made for, it will not delete local copies for now.

Just test it, and I will push new codes.

rohitcoder avatar Aug 07 '20 03:08 rohitcoder

Im going to try that, the thing is the server is low on disk space so I hope we can use this setting to save some space.

Thank you, by the way nice job with this script

jnar avatar Aug 08 '20 14:08 jnar

Ok I have an update here, did some changes in script...

First I declared an array for filetypes I dont want to upload: KEEP_FILE_EXTENSIONS=['csv','json','xml','svg','png']

Then I put a new condition before deleting files: extonly=os.path.splitext(elem)[1][1:] if(extonly not in KEEP_FILE_EXTENSIONS): remove(elem)

This way files like metadata.xml and thumbnails stay in server and nothing looks weird in GL.

This is what I got so far, Im thinking in the best way to manage this to prevent an impact in performance later if folders grow much.

jnar avatar Aug 08 '20 16:08 jnar

Can you just try it by uploading everything of a meeting folder to s3 and just keeping a blank folder with that meeting Name?

Let's see if that works, then you could save more space!

For example: If there is a meeting folder named 75798d75e10388ae7e43f4e59de0d956-12121212 and it contains multiple files, then run bbb-s3.py script and upload everything to s3 and just keep that folder empty (but that folder should be there.) and then see, if this works, In case it not works i think we need to change routing of file serving URL something like we did in this part (from our docs) Screenshot 2020-08-08 at 10 25 37 PM

rohitcoder avatar Aug 08 '20 16:08 rohitcoder

I considered that approach but there are some thumbnails that GL uses and look for them in local directory so I decided too keep all files except for big ones

jnar avatar Aug 08 '20 17:08 jnar

Ok, can you please create a new bbb-s3-gL.py and add PR?

Or let me know, if you want to share final bbb-s3-gl.py via pastebin.com ?

It would be good for other ones

rohitcoder avatar Aug 08 '20 18:08 rohitcoder

Sure, Im gonna share when I feel its kinda ready

jnar avatar Aug 08 '20 20:08 jnar