rbt icon indicating copy to clipboard operation
rbt copied to clipboard

Published 20 hours ago • verified publisher icon roc-lang

Require review from other code owner

Open Anton-4 opened this issue 4 years ago • 4 comments

The way to go seems to be to:

  • [ ] set up CODEOWNERS
  • [ ] require one review for the trunk branch
  • [ ] require reviews from CODEOWNERS

The CODEOWNERS file should be set up to have at least two trusted contributors as code owners per folder. That way every PR will be reviewed by a (different) trusted contributor.

  • [ ] Verify settings by trying to merge PR with review from someone who is not a code owner.

Anton-4 avatar Jul 13 '21 12:07 Anton-4

I'd like to set up a group like @roc-lang/rbt-reviewers for this. @rtfeldman what do you think? Based on activity so far, it'd maybe be you, me, and @bhansconnect?

BrianHicks avatar Aug 25 '22 20:08 BrianHicks

ping @rtfeldman! I'm about to open another PR assigning basically this group. Would it make sense or shall we skip it?

BrianHicks avatar Sep 02 '22 19:09 BrianHicks

rbt-reviewers sounds good! 👍

rtfeldman avatar Sep 03 '22 17:09 rtfeldman

Would you mind creating that group? I can set CODEOWNERS up afterwards but I am not a member of the roc-lang org with sufficient permissions to make a group.

BrianHicks avatar Sep 06 '22 16:09 BrianHicks