Graphic.js: darker green for qsubcolor1

[glasser]

This makes the green color used for qsubcolor1 (eg, for slither) darker and thus more distinguishable from the yellow used for qsubcolor2 by people with some forms of colorblindness.

The particular color chosen is inspired by https://sashamaps.net/docs/resources/20-colors/ though I am not tweaking the other colors to come from here.

Fixes #255.

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
pzprjs	✅ Ready (Inspect)	Visit Preview	Nov 18, 2022 at 0:21AM (UTC)

[glasser]

Hmm, this is probably too close to the default (not "color each line") line color:

[codecov-commenter]

Codecov Report

Base: 88.58% // Head: 88.58% // No change to project coverage :thumbsup:

Coverage data is based on head (a0528cb) compared to base (f666ceb). Patch has no changes to coverable lines.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #280   +/-   ##
=======================================
  Coverage   88.58%   88.58%           
=======================================
  Files         164      164           
  Lines       17927    17927           
=======================================
  Hits        15880    15880           
  Misses       2047     2047           

Impacted Files	Coverage Δ
src/puzzle/Graphic.js	94.91% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

[robx]

Yeah I don't think we should go for darker shading. I was hoping (one of) the shades could be tweaked to something that's more apparently different from the other, without increasing the "contrast" in terms of darkness.

[glasser]

Well, the contrast in terms of darkness is admittedly what many colorblind folks can see — but if you're comfortable just completely changing a color then that works too. I use pink as my secondary color in penpa fwiw.

[robx]

So what would be ideal is to have a change that keeps looking "nice" for everyone but is better in terms of accessibility, and particularly good enough for you. I'm not opposed to switching out the colors within those parameters.

I don't know enough about the various forms of color blindness to be able to tell whether it's realistic to find a single color scheme that works, there.

If that doesn't work, I think the best alternative would be to add some kind of accessibility toggle (whether that be via stylesheet or a menu option) which would switch out the color scheme, and then you can go wild with how you'd like puzzles to look in "accessible mode". (Needn't be a single option if that's not selective enough, but it would be a good start.) That needn't be limited to changing the colors, e.g. it would be possible to draw thin XOs for the two shadings.