create-issue-branch icon indicating copy to clipboard operation
create-issue-branch copied to clipboard

Bug where issues created by Convert to issue in Project did not trigger actions

Open uyeonyx opened this issue 2 years ago • 2 comments

Hi, @robvanderleek 👋

Thanks for adding skipBranch the other day. It's been really helpful.

Good to see you again.


I am using a mix of GH Project with your product in my enterprise. For the most part, I think everything works beautifully with no issues, but there is one issue. I am able to create a Draft via Add Item in a project. And I can convert the draft to an issue via Convert to issue. The issue will be created in the repository where create-issue-branch is installed. The problem with this is that the issue will not automatically create a PR, even if the assignor and labeling are chosen correctly. Conversely, when you create an issue in the repository, link it to a project and expose it, everything works fine.

I'm attaching a screenshot for better understanding.


image image

Create an issue by creating a Draft and selecting a repository via Convert to issue, as shown in the first image.

I then specify Assignees and Labels to make create-issue-branch work.

However, as you can see in the second image, nothing happens. (Even after reassigning the assignees and labels, it still doesn't work).


image

However, if I just create an issue in the repository and link it to your project like you've always done, it will (of course) work and look great.


Here's my issue-branch.yaml.

defaultBranch: 'develop'
branchName: '${issue.number}:${issue.title,}'
gitSafeReplacementChar: '-'
branches:
  - label : feature
    prefix: feature/
    name: develop
    prTarget: develop
    skip: false
  - label : bug
    prefix: bugfix/
    name: develop
    prTarget: develop
    skip: false
  - label : critical
    prefix: hotfix/
    name: master
    prTarget: master
    skip: false
  - label : 'release: staging'
    name: develop
    prTarget: release
    skipBranch: true
    skip: false
  - label : 'release: production'
    name: release
    prTarget: master
    skipBranch: true
    skip: false
  - label : '*'
    skip: true


prSkipCI: true
copyIssueDescriptionToPR: true
copyIssueLabelsToPR: true
copyIssueAssigneeToPR: true
openDraftPR: true
commentMessage: "✅ Work Branch Created!\n```git checkout ${branchName}```\ncopy this 👆"
autoCloseIssue: true

uyeonyx avatar Oct 24 '23 02:10 uyeonyx

Hi @uyeonyx

I'm not an experienced GH Projects user myself but I tried to reproduce your problem. However, when I create a draft item on the project board, and convert it to an issue in a repository, Create Issue Branch seems to work fine:

For example, I have a test board here: image

On the test board I can create draft issues and convert those items to issues in a repository where the Create Issue Branch App is installed: https://github.com/facio-ergo-sum/test-repo-create-issue-branch-prod-app/issues/48

I did notice that updates of the issue comments on the project board are slow (issue comment updates in the repository are a lot faster). Can you check the issue in the repository to see if Create Issue Branch did its work?

I'm not sure if you can create issues on the test project board, but if you can feel free to experiment.

HTH, Rob

robvanderleek avatar Oct 24 '23 21:10 robvanderleek

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 15 '23 03:12 stale[bot]