vanilla icon indicating copy to clipboard operation
vanilla copied to clipboard

0.3.0 broke something on macOS 10.10

Open justvanrossum opened this issue 2 years ago • 11 comments

In FontGoggles, clicking on the "Variations" tab makes the whole tab move to the bottom of the parent, rendering it unusable.

0.3.0: image

0.2.4: image

This does not seem to happen on macOS 10.15.

It may not be worth fixing this, but I thought I could at least document it.

justvanrossum avatar May 23 '23 07:05 justvanrossum

macOS 10.10 is released in 2014....

I guess a more clear statement of vanilla support over different macOS version could help here...

We should consider that we cannot keep up supporting the latest macOS with losing older macOS versions.

typemytype avatar May 23 '23 08:05 typemytype

What would be the next reasonable lowest version? 10.15? 10.14?

justvanrossum avatar May 23 '23 08:05 justvanrossum

no idea...

things to consider:

  • py3.9 EOL is October 2025
  • switch between intel M1
  • M1 is only Monterey+

typemytype avatar May 23 '23 08:05 typemytype

does it happens for each tab view? or only a tab view inside a splitview?

maybe a small example?

the change in vanilla was a move for the tab view to a NSTabViewController

typemytype avatar May 23 '23 09:05 typemytype

Hard to say, I but I'll try to make a small reproducer.

justvanrossum avatar May 23 '23 09:05 justvanrossum

I got a report of a similar issue affecting macOS 11.7 https://github.com/Nagwa-Limited-Community/Glyphs-MATH-Plugin/issues/5

khaledhosny avatar May 23 '23 14:05 khaledhosny

Related: SegmentedButton doesn’t respect posSize for me on Mac OS 12.3.1

Screenshot: image

Test case:

import vanilla

def run():
    w = vanilla.Window(
        (400, 400),
    )
    w.btn = vanilla.SegmentedButton(
        (10, 10, -10, 20),
        [
            dict(title="Very Long Title"),
            dict(title="Another Long Title"),
            dict(title="Long Title Indeed"),
        ],
    )

    w.open()
    w.center()

run()

Same code executed with executeVanillaTest works fine: image

chrisjansky avatar Jun 01 '23 17:06 chrisjansky

could you test with the latest vanilla from the repo? the vanilla version on pypi is behind

typemytype avatar Jun 05 '23 11:06 typemytype

@typemytype Not sure I follow, I am using vanilla v0.3.0 which looks like the latest version here on GitHub Releases also

chrisjansky avatar Jun 12 '23 16:06 chrisjansky

true, but the latest commit is newer and already fixed this issue, sorry for being lazy on the releases

pip3 install git+https://github.com/robotools/vanilla to install the latest from this repo

typemytype avatar Jun 12 '23 20:06 typemytype

This issue still persist, even in the latest version in git.

justvanrossum avatar May 25 '24 13:05 justvanrossum