yarp icon indicating copy to clipboard operation
yarp copied to clipboard

Probably useless part in yarp.i

Open drdanz opened this issue 4 years ago • 0 comments
trafficstars

I think that this part in the yarp.i file might be useless:

https://github.com/robotology/yarp/blob/13d2bc8ea92621b29055d10c6dbc43809f35c1b0/bindings/yarp.i#L447-L466

It looks like something that might have been there when toString() was returning ConstString, and it comes from the first commit ever to the yarp.i file, 15 years ago. See d64589665f0e27ed611716a9716ef5c4e9ad8359

toString() is now returning a std::string, therefore the functions included seem useless.

Also relevant, a few lines above:

https://github.com/robotology/yarp/blob/13d2bc8ea92621b29055d10c6dbc43809f35c1b0/bindings/yarp.i#L101

https://github.com/robotology/yarp/blob/13d2bc8ea92621b29055d10c6dbc43809f35c1b0/bindings/yarp.i#L160

https://github.com/robotology/yarp/blob/13d2bc8ea92621b29055d10c6dbc43809f35c1b0/bindings/yarp.i#L171-L174

https://github.com/robotology/yarp/blob/13d2bc8ea92621b29055d10c6dbc43809f35c1b0/bindings/yarp.i#L181-L186

https://github.com/robotology/yarp/blob/13d2bc8ea92621b29055d10c6dbc43809f35c1b0/bindings/yarp.i#L214

drdanz avatar Nov 26 '20 16:11 drdanz