yarp icon indicating copy to clipboard operation
yarp copied to clipboard

updateReply is never called when a portmonitor is connected on the receiver side

Open drdanz opened this issue 5 years ago • 2 comments
trafficstars

When a portmonitor is attached on the sender side, accept, update and updateReply are called correctly. The same should happen when it is attached on the receiver side, but instead only the accept and update methods are called.

drdanz avatar Oct 09 '20 16:10 drdanz

As shown by #2382, this issue comes from ModifyingCarrier that does not call modifyReply on the receiver side.

We should probably rename modifyReply for coherence with the other names, but modifyIncomingReply or modifyOutgoingReply might be a little confusing though, since it is an incoming reply for an outgoing message. Perhaps modifyOutgoingDataReply would be less confusing?

Then a modifyIncomingDataReply method should be added and called in the right place.

Finally we can enhance the MonitorObject interface to support both replies.

drdanz avatar Oct 12 '20 09:10 drdanz

The failing tests were disabled in 8ea360b87579c64733cdbf17f78063d8c45dc8bf

drdanz avatar Nov 02 '20 15:11 drdanz