human-dynamics-estimation icon indicating copy to clipboard operation
human-dynamics-estimation copied to clipboard

Make dependency on robometry optional and add it in the documentation

Open lrapetti opened this issue 3 years ago • 3 comments
trafficstars

In https://github.com/robotology/human-dynamics-estimation/pull/298 we forgot to update the documentation with the robometry dependency.

lrapetti avatar Oct 21 '22 07:10 lrapetti

Note that the library is still marked as Under Development. We might think of making this dependency optional

lrapetti avatar Oct 21 '22 07:10 lrapetti

Note that the library is still marked as Under Development. We might think of making this dependency optional

If we want to make it optional we should address it also in the device CMakeLists.txt

RiccardoGrieco avatar Oct 21 '22 08:10 RiccardoGrieco

Note that the library is still marked as Under Development. We might think of making this dependency optional

If we want to make it optional we should address it also in the device CMakeLists.txt

Yess, it has been addressed in https://github.com/robotology/human-dynamics-estimation/pull/323/commits/165183da985950e8524b091814c96ba8825ce4cd. I have changed the title of the PR to reflect this change

lrapetti avatar Oct 22 '22 07:10 lrapetti

@RiccardoGrieco do you have any further comment or can we merge it?

lrapetti avatar Nov 18 '22 10:11 lrapetti